Incorrect expr_type for variables

[GoogleCodeExporter]

What steps will reproduce the problem?
1. execute this code :

$parser = new PHPSQLParser();
$sql = "update table set column=@max;";
$parser->parse($sql);

2. In the returned array, "@" is identified as "colref" and "max" as an 
"aggregate_function":
...
                            [2] => Array
                                (
                                    [expr_type] => colref
                                    [base_expr] => @
                                    [sub_tree] => 
                                )

                            [3] => Array
                                (
                                    [expr_type] => aggregate_function
                                    [base_expr] => max
                                    [sub_tree] => 
...

What is the expected output? What do you see instead?
...
                            [2] => Array
                                (
                                    [expr_type] => user_defined_variable
                                    [base_expr] => @max
                                    [sub_tree] => 
                                )
...

What version of the product are you using? On what operating system?
r303, Ubuntu 12.04

Please provide any additional information below.
If the variable name is not a keyword, it is identified as a colref:
...
                            [2] => Array
                                (
                                    [expr_type] => colref
                                    [base_expr] => @
                                    [sub_tree] => 
                                )

                            [3] => Array
                                (
                                    [expr_type] => colref
                                    [base_expr] => not_keyword
                                    [sub_tree] => 
                                )
...

Original issue reported on code.google.com by marisr...@gmail.com on 20 Aug 2012 at 7:27

• Merged into: #67

[GoogleCodeExporter]

That is the same problem as issue 67.

Original comment by pho...@gmx.de on 20 Aug 2012 at 7:59

• Changed state: Duplicate

[GoogleCodeExporter]

Check out r308, it solves the problem. Is it ok to set user_variable instead of 
user_defined_variable?

Original comment by pho...@gmx.de on 20 Aug 2012 at 10:12

[GoogleCodeExporter]

Either name it's OK.

I took the name from mysql docs title "9.4. User-Defined Variables", but if you 
look at it's content both versions are use for the same purpose.

Original comment by marisr...@gmail.com on 20 Aug 2012 at 10:20