alisases issue

[GoogleCodeExporter]

I found an issue with using aliases that have a . or space in them, this line
~505 in php-sql-creator.php
[code] $sql .= " " . $parsed['alias']['name']; [/code] 
in processAlias method should be:
[code] $sql .= " `" . $parsed['alias']['name']."` "; [/code]

then anything can be used for an alias

Original issue reported on code.google.com by i...@theorganicagency.com on 25 Oct 2013 at 10:09

[GoogleCodeExporter]

I think, this could be better solved within the parser.

Original comment by pho...@gmx.de on 1 Nov 2013 at 3:55

• Changed state: Accepted

[GoogleCodeExporter]

I'm not sure if it's really a parser problem, it's more that the alias should 
always be contained within backticks

Original comment by i...@theorganicagency.com on 1 Nov 2013 at 4:18

[GoogleCodeExporter]

I try to generate SQL with the Creator, which is as close as possible to the 
original SQL statement, which the parser splits. The alias hasn't always 
backticks, so I think, the parser should keep the backticks, but shouldn't add 
one. If I keep the backticks, there are some side-effects (i.e. with the order 
clause). Maybe I could add another property like "quoted" or something. The 
creator could generate backticks only for quoted==true.

Original comment by pho...@gmx.de on 1 Nov 2013 at 6:26

[GoogleCodeExporter]

Original comment by pho...@gmx.de on 5 Nov 2013 at 8:49

• Changed state: Started

[GoogleCodeExporter]

I have fixed your issue, see r433.

Original comment by pho...@gmx.de on 5 Nov 2013 at 4:18

• Changed state: Fixed