search

ricnaaru / adv_camera

Advanced Camera for Flutter
BSD 3-Clause "New" or "Revised" License
54 stars 35 forks source link

Fix for exporting images with correct resolution in landscape mode #10

Closed MohsinN closed 4 years ago

MohsinN commented 4 years ago

Current implementation for android does not take into account the change in orientation when picture is taken in landscape mode. Resulting in wrong resolution for output images. This fix ensures that output resolution is same for portrait and landscape mode.

ricnaaru commented 4 years ago

Supposedly will try to fix the landscape problem. Now Android has many devices from many different manufactures out there, so i'm not sure this will make it right on just particular device, but i will put this change up, temporarily

MohsinN commented 4 years ago

Hi 👋

I doubt that will be a problem as it only takes width and height of image into account to detect the orientation.

Please let me know if I can help to address this problem or contribute to any other feature. Would be glad to help out.

ricnaaru commented 4 years ago

i've tried various solution to really tune the orientation on android, tried on Oppo, Xiaomi, Samsung, Huawei, Advance even (i believe it's indonesian trademark), and it's been almost one year, that i forgot whatever i tried back in the days.. so i'm not quite sure.. that note is just to remind my self in the future if there's some problem with the orientation.. i really appreciate your help.. thanks :)

On Thu, Jun 4, 2020 at 1:57 PM Mohsin notifications@github.com wrote:

Hi 👋

I doubt that will be a problem as it only takes width and height of image into account to detect the orientation.

Please let me know if I can help to address this problem or contribute to any other feature. Would be glad to help out.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/ricnaaru/adv_camera/pull/10#issuecomment-638643807, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIBAC6KRXO7WCQ7RFFVG5HDRU5AULANCNFSM4KOC5WEQ .