search

ricoberger / script_exporter

Prometheus exporter to execute scripts and collect metrics from the output or the exit status.
MIT License
354 stars 82 forks source link

Logging and env vars #65

Closed fgouteroux closed 1 year ago

fgouteroux commented 1 year ago

Hello @ricoberger

First, thank for your work.

I want to add some enhancement logging, support windows event log when running as a service, and support environment vars in script config. Could you have a look on this, please ?

ricoberger commented 1 year ago

Hi @fgouteroux awesome work, thank you very much 🙂.

Two smaller things:

  1. Maybe os.Environ() can always be used, see my other comment
  2. Can you please add the env key to the yaml schema in the readme (line 90). Maybe a short note in the sentence after the schema in the readme makes also sense.
fgouteroux commented 1 year ago

@ricoberger Thanks, I applied your suggestions.

ricoberger commented 1 year ago

Hi @fgouteroux thanks again 🙂. I published a new version v2.8.0 with your changes.