Closed PatrickKoss closed 1 year ago
Hi @PatrickKoss thanks for your contribution 🙂.
Does it make sense to add a new test in https://github.com/ricoberger/vault-secrets-operator/tree/main/hack similar to the other authentication methods?
Yes @ricoberger it of course makes sense. I was just not aware of the tests :D Added one for username and password. Can you have a look again?
Awesome work @PatrickKoss and thanks for adding the test.
I think there is only a problem with the file permissions for the added test, which should be fixed by running chmod +x hack/setup-kind-userpass.sh
, everything else is looking good.
@ricoberger executed the command, so hopefully should work now
Thank you 🙂
Hey :)
I like this project and used it happily in the past. Now I have to use a secrets manager (vault) that currently only support username and password auth. Therefore I think it will be useful (at least for me) to add the userpass auth method.
Best regards, Patrick