ricoberger / vault-secrets-operator

Create Kubernetes secrets from Vault for a secure GitOps based workflow.
MIT License
633 stars 103 forks source link

add username and password auth method #203

Closed PatrickKoss closed 1 year ago

PatrickKoss commented 1 year ago

Hey :)

I like this project and used it happily in the past. Now I have to use a secrets manager (vault) that currently only support username and password auth. Therefore I think it will be useful (at least for me) to add the userpass auth method.

Best regards, Patrick

ricoberger commented 1 year ago

Hi @PatrickKoss thanks for your contribution 🙂.

Does it make sense to add a new test in https://github.com/ricoberger/vault-secrets-operator/tree/main/hack similar to the other authentication methods?

PatrickKoss commented 1 year ago

Yes @ricoberger it of course makes sense. I was just not aware of the tests :D Added one for username and password. Can you have a look again?

ricoberger commented 1 year ago

Awesome work @PatrickKoss and thanks for adding the test.

I think there is only a problem with the file permissions for the added test, which should be fixed by running chmod +x hack/setup-kind-userpass.sh, everything else is looking good.

PatrickKoss commented 1 year ago

@ricoberger executed the command, so hopefully should work now

ricoberger commented 1 year ago

Thank you 🙂