ricokahler / sanity-super-pane

The Sanity Desk Tool Pane with Super Powers
sanity-super-pane.vercel.app
MIT License
101 stars 12 forks source link

feat: add basic search functionality #29

Closed Jesperpaulsen closed 3 years ago

Jesperpaulsen commented 3 years ago

This PR introduces basic search functionality by doing a simple string matching for a given field.

Was a bit unsure about the naming convention for stuff I introduced, as I normally would have called it something related to query. However, since we're adding a "query" to an already defined query, I tried to stay away from calling the variables something with query.

Haven't contributed that much to open source before, so let me know if there is anything I should change. Have realized it probably should have been called custom filter instead of search functionality?

vercel[bot] commented 3 years ago

Someone is attempting to deploy a commit to a Personal Account owned by @ricokahler on Vercel.

@ricokahler first needs to authorize it.

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/ricokahler/sanity-super-pane/GKyzuLahcoZA2XBLoimUMSuWmUXP
✅ Preview: https://sanity-super-pane-git-fork-fnatic-feature-bas-5956c6-ricokahler.vercel.app

ricokahler commented 3 years ago

hey @Jesperpaulsen, this is looking really great! Definitely a lot of value in this feature

CleanShot 2021-08-13 at 09 04 06@2x

Haven't contributed that much to open source before, so let me know if there is anything I should change. Have realized it probably should have been called custom filter instead of search functionality?

Not an issue at all, opening this PR is the right direction 🤠. I'll leave a review and we can get this going. Thanks for contributing!

Jesperpaulsen commented 3 years ago

this is looking really good! I left some comments (mostly stylistic to match existing conventions) but besides i'm willing to merge this 🎉

thanks for contributing

Awesome, thanks a lot for the great feedback @ricokahler 🤠 🙇 Will go through and fix the code. What will be the correct commit message type for angular commit messages when fixing the feature? Refactor?