State issues when deleting documents

coreyward commented 3 years ago

This might not be specific to deleting documents, but it's the workflow I was using when I encountered them:

After deleting a bunch of documents via bulk actions…
- …the selected items count does not update.
- …the documents remaining in the pane do not refresh.
- …pagination numbers do not update (instead show stale values)
When proceeding to a subsequent page after deleting items, adding additional items to the selection increases the “items selected” indicator beyond the number possible (i.e. it's never removing the deleted documents from the count)
It's possible to paginate to a page greater than the number of remaining pages when the above occurs, resulting in empty panes

Also, minor visual issue: when entering into the editor view the status label winds up wrapping each letter individually, causing the rows of the pane (list items) to be excessively tall.

By the way, thank you for putting in the time to get this thing this far. It's already super useful and I can't wait to be able to ship it as the default pane for all views in the Studio! If I were better at TypeScript I'd contribute (would love to add fuzzy search filtering, sorting columns, and inline edits to name a few). Maybe later this year!

ricokahler commented 3 years ago

Thanks for the bug report and testing out the alpha!

This is all great feedback and I think I can fix most of them just by refreshing and clearing after a delete. I was struggling to figure out what should be the correct behavior for the selection after a bulk action and it's clear to me now that the current logic needs some work 😅.

Also, minor visual issue: when entering into the editor view the status label winds up wrapping each letter individually, causing the rows of the pane (list items) to be excessively tall.

I'm having some trouble reproducing this. What browser are you using? Can you provide a screenshot as well?

By the way, thank you for putting in the time to get this thing this far. It's already super useful and I can't wait to be able to ship it as the default pane for all views in the Studio! If I were better at TypeScript I'd contribute (would love to add fuzzy search filtering, sorting columns, and inline edits to name a few). Maybe later this year!

I'm glad you're interested! I'm a fan of your projects in the sanity world as well.

I'm hoping this thing can take on a good amount of community contributions and solve a bunch of collective problems we all have. If you'd like to contribute in javascript, I can add the types later.

ricokahler commented 3 years ago

https://github.com/ricokahler/sanity-super-pane/pull/4#issuecomment-808834471

coreyward commented 3 years ago

Thanks for tackling the refresh issue so fast! Here's a screenshot of the label wrapping behavior I'm seeing (in Chrome):

ricokahler / sanity-super-pane

State issues when deleting documents #3