search

ricosjp / truck

Truck is a Rust CAD Kernel.
Apache License 2.0
1.02k stars 53 forks source link

Cylindrical surface parsing #30

Closed g-rauhoeft closed 1 year ago

g-rauhoeft commented 2 years ago

I'll open draft pull requests so you can see what I'm working on if that's ok. I have quite a few step files that contain cylindrical surfaces, so here is my still unfinished implementation of the pipeline from STEP to truck for these.

ytanimura commented 2 years ago

There is no problem with the way the surface is added to Table.

I am afraid if you have noticed, the sweeping vector in https://github.com/ricosjp/truck/pull/30/files#diff-d3a3982e7a3577fe7a8eecc1d1f4e2264bd7329ecdce9dc0d72c850fc2b4a63dR1115 should be Vector3::unit_z().

g-rauhoeft commented 2 years ago

Indeed, thank you for your feedback! It's still a draft, so I'm changing it a lot. I changed the definition of a cylinder to something closer to the IFC definition. Still heavily work in progress. A lot of what's in cylinder.rs was copied over from sphere.rs, so isn't actually correct for a cylinder yet.

ytanimura commented 2 years ago

We have a need to use cylindicalsurface on my end as well. What is the current situation here? We can make a continuation if you like.