search

ricosjp / truck

Truck is a Rust CAD Kernel.
Apache License 2.0
992 stars 53 forks source link

Handle Axis2Placement parallel to x-axis without reference #64

Open larsniem opened 4 months ago

larsniem commented 4 months ago

Hi, first thank you for your great work, I really enjoy playing around with it in some little projects so far.

This is also how I stumbled over an untested case in the stepio crate, which caused some trouble. The cause is an AxisPlacement which is parallel to the global x-axis and also no reference is given for the AxisPlacement. The solution is more or less trivial, by just avoiding the artificial reference axis being parallel to the actual axis. Choosing the y-axis instead resolved the issue.

I adopted the existing tests for verification. I'm not really sure if the solution of the issue and tests meet your expectations, there are definitely other possible solutions.

CLAassistant commented 4 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.