ricrpi / mupen64plus-video-gles2n64

Manually ported from mupen64plus-ae for use with the Raspberry PI
5 stars 10 forks source link

Neon CFLAGS for RPI2 #8

Closed NF3RN0 closed 9 years ago

NF3RN0 commented 9 years ago

CFLAGS += -mfpu=neon

gizmo98 commented 9 years ago

The intention was 'let the user pass CFLAGS with -mfpu=neon'. The rpi2 supports -mfpu=neon-vfp4. But this flag is not backward compatible with cortex-a8 or cortex-a9 cores.

ricrpi commented 9 years ago

@gizmo98

If the user passes in CFLAGS then the whole of CFLAGS will need to be passed in as the makefile doesn't use (overridable?) to add to it. Not got the brain power at the minute to fix this issue.

gizmo98 commented 9 years ago

Sorry. RetroPie-Setup uses OPTFLAGS to pass this information.

ricrpi commented 9 years ago

actually I can use OPTFLAGS too to fix this. Does RetroPie also pass in '-flto' for OPTFLAGS because it will be overridden within the makefile.

ricrpi commented 9 years ago

@NF3RN0 I have defined OPTFLAGS within RaspbianList_Pi2 so when using the build script, you should now get -mfpu=neon passed into the compiler.

gizmo98 commented 9 years ago

Yeah. Link time optimization flag will be overridden. Have you tested if the plugin runs faster with -flto?

ricrpi commented 9 years ago

Afraid not and can't test at the moment - working away from home and ssh fails to connect.