search

ricsanfre / ansible-role-minio

Ansible role for installing and configuring Minio
https://galaxy.ansible.com/ricsanfre/minio
MIT License
50 stars 22 forks source link

feat: allow install to system-wide Python #14

Closed rjhenry closed 5 months ago

ricsanfre commented 6 months ago

Hi @rjhenry, thanks for creating this PR,

Instead of adding a hardcoded environment variable in the Ansible's playbook, I would rather prefer to have a new Ansible var pip_environment_var containing a list of environment variables that need to be passed to pip command execution.

Could you please update the PR so that generic variable can be used?

Thanks Regards Ricardo

rjhenry commented 6 months ago

Instead of adding a hardcoded environment variable in the Ansible's playbook, I would rather prefer to have a new Ansible var pip_environment_var containing a list of environment variables that need to be passed to pip command execution.

I went with minio_pip_environment_vars, mostly to indicate the scope of the variable in it's name.

rjhenry commented 5 months ago

Looks like those Molecule tests are a) only warnings and b) also happening on master now. I suspect something's updated somewhere or similar?

ricsanfre commented 5 months ago

Currently there is an issue, https://github.com/ansible-collections/community.docker/issues/860, making ansible docker package not workig and so "molecule" workflows are broken. There is a molecule, PR https://github.com/ansible/molecule/pull/4185 fixes this issue, so I won`t apply workarround in github actions to avoid installation of the broken package.