rid00z / FreshMvvm

FreshMvvm is a super light Mvvm Framework designed specifically for Xamarin.Forms. It's designed to be Easy, Simple and Flexible.
Apache License 2.0
594 stars 172 forks source link

Xamarin Forms 4 Compatibility #250

Open minaairsupport opened 5 years ago

minaairsupport commented 5 years ago

I am wondering if this library will be compatible with XF 4 with Shell experience

var welcomePage = FreshPageModelResolver.ResolvePageModel<WelcomePageModel>();

this error fired when I tried resolve viewModel

Note I change ContentPage to Shell

Resolve failed: WelcomePage - Reason: Specified cast is not valid. (FreshTinyIoC.TinyIoCResolutionException)
  at FreshTinyIoC.FreshTinyIoCContainer.ConstructType (System.Type requestedType, System.Type implementationType, System.Reflection.ConstructorInfo constructor, FreshTinyIoC.NamedParameterOverloads parameters, FreshTinyIoC.ResolveOptions options) [0x0015f] in <518460ffbfc5451e9dec2c932b3d8010>:0 
  at FreshTinyIoC.FreshTinyIoCContainer.ConstructType (System.Type requestedType, System.Type implementationType, FreshTinyIoC.NamedParameterOverloads parameters, FreshTinyIoC.ResolveOptions options) [0x00000] in <518460ffbfc5451e9dec2c932b3d8010>:0 
  at FreshTinyIoC.FreshTinyIoCContainer.ResolveInternal (FreshTinyIoC.FreshTinyIoCContainer+TypeRegistration registration, FreshTinyIoC.NamedParameterOverloads parameters, FreshTinyIoC.ResolveOptions options) [0x001ba] in <518460ffbfc5451e9dec2c932b3d8010>:0 
  at FreshTinyIoC.FreshTinyIoCContainer.Resolve (System.Type resolveType) [0x00011] in <518460ffbfc5451e9dec2c932b3d8010>:0 
  at FreshMvvm.FreshTinyIOCBuiltIn.Resolve (System.Type resolveType) [0x00000] in /Users/michaelridland/Projects/FreshMvvm/src/FreshMvvm/FreshTinyIOCBuiltIn.cs:48 
  at FreshMvvm.FreshPageModelResolver.ResolvePageModel (System.Type type, System.Object data, FreshMvvm.FreshBasePageModel pageModel) [0x00027] in /Users/michaelridland/Projects/FreshMvvm/src/FreshMvvm/FreshPageModelResolver.cs:41 
  at FreshMvvm.FreshPageModelResolver.ResolvePageModel[T] (System.Object data, T pageModel) [0x0000b] in /Users/michaelridland/Projects/FreshMvvm/src/FreshMvvm/FreshPageModelResolver.cs:25 
  at FreshMvvm.FreshPageModelResolver.ResolvePageModel[T] (System.Object initData) [0x0000b] in /Users/michaelridland/Projects/FreshMvvm/src/FreshMvvm/FreshPageModelResolver.cs:19 
  at FreshMvvm.FreshPageModelResolver.ResolvePageModel[T] () [0x00000] in /Users/michaelridland/Projects/FreshMvvm/src/FreshMvvm/FreshPageModelResolver.cs:12 
  at AgentWay.App.RegisterFirstPage () [0x00001] in /Users/mina/AgentWay.Mobile/AgentWay/App.xaml.cs:47 
  at AgentWay.App..ctor () [0x00016] in /Users/mina/AgentWay.Mobile/AgentWay/App.xaml.cs:32 
  at AgentWay.iOS.AppDelegate.FinishedLaunching (UIKit.UIApplication app, Foundation.NSDictionary options) [0x000fd] in /Users/mina/AgentWay.Mobile/AgentWay.iOS/AppDelegate.cs:80 
  at (wrapper managed-to-native) UIKit.UIApplication.UIApplicationMain(int,string[],intptr,intptr)
  at UIKit.UIApplication.Main (System.String[] args, System.IntPtr principal, System.IntPtr delegate) [0x00005] in /Library/Frameworks/Xamarin.iOS.framework/Versions/12.2.1.12/src/Xamarin.iOS/UIKit/UIApplication.cs:79 
  at UIKit.UIApplication.Main (System.String[] args, System.String principalClassName, System.String delegateClassName) [0x0002c] in /Library/Frameworks/Xamarin.iOS.framework/Versions/12.2.1.12/src/Xamarin.iOS/UIKit/UIApplication.cs:63 
  at AgentWay.iOS.Application.Main (System.String[] args) [0x00001] in /Users/mina/AgentWay.Mobile/AgentWay.iOS/Main.cs:17 
libin85 commented 5 years ago

@minaairsupport : Do you have a sample project that you can attach where it fails. It will helps us to get onto it sooner.

minaairsupport commented 5 years ago

I dont have now but XF4 introduce new concept called Shell so we must be ready for using it , it will be stable soon

rid00z commented 5 years ago

@minaairsupport Thanks for the input, we will be working with the XF to ensure we support XF 4.0 and shell when it's released.

itoshinji commented 5 years ago

have been released!

navkar commented 5 years ago

Anyone tried using FreshMVVM with XF shell?

gazwinter commented 5 years ago

@navkar I don't think XF Shell is in the current release of FreshMvvm. The guys are probably still working on it

thiagoparabas commented 5 years ago

When it's released?

ghuntley commented 5 years ago

@thiagoparabas as soon as you pitch in and help 👍

rejy11 commented 5 years ago

I think once the below item has been completed, mvvm frameworks such as FreshMvvm can start working on it.

https://github.com/xamarin/Xamarin.Forms/issues/5166

minaairsupport commented 4 years ago

any plane to support Shell?

rid00z commented 4 years ago

Yes, shell support will happen once Shell can support Mvvm.

Geronatsios commented 2 years ago

any news to support Shell mvvm ?