Closed RobertGemmaJr closed 2 years ago
Visit the preview URL for this PR (updated for commit effa559):
https://riddc-volume-viewer--pr35-sidebar-controls-cto7r5b8.web.app
(expires Tue, 05 Oct 2021 14:03:57 GMT)
🔥 via Firebase Hosting GitHub Action 🌎
There is a small bug with the widths of the color map images in the dropdown button. I imagine it has something to do with the flexbox stuff? Would appreciate an extra set of hands
Would it be possible to make the color map drop down show the current value instead of being a button?
I think it's fine the sidebar is in the way of the header for the moment. The behavior is predictable, if not ideal.
I would have the dropdown show the values (if possible), then add the selected one tightly below or above the transfer function at the same width as the canvas there.
Right now the canvas is building its own custom size. I'm not really sure how we'd get it to size to the width of the of the canvas.
I can try to figure out the redux to get the current color map and display it in the OpacityControl.js
component though. Working on the new dropdown button now
Right now the canvas is building its own custom size. I'm not really sure how we'd get it to size to the width of the of the canvas.
It looks like the width of the canvas is set via prop, so can just match that hardcoded for the moment?
It looks like the width of the canvas is set via prop, so can just match that hardcoded for the moment?
From what I can tell, in OpacityControl.js
var controlsContainer = document.getElementById("controls");
this.opCanvas.width =
controlsContainer.clientWidth - 2 * this.padding - 2;
controlsContainer
is null when I try that in ColorMappingController.js
The dropdown now always takes up 100% of it's container. I had to do style={{width: "100%"}}
in two places.
There has to be a better way to do it but I can't figure it out
volumeData
from redux (now inVolumeContext
Sidebar
inline stylereact-bootstrap
buttons (was html)Sidebar
now takes full with of the screen. Still sits on the left side, should we move to the bottom? I don't think that would look as natural but would get it out of the way of the header.