Feat sidebar 2 - Githubissues

ridatadiscoverycenter / react-aframe-volume-renderer

afreame-webgl2 volumen renderer as a reactjs app

MIT License

3 stars 0 forks source link

Feat sidebar 2 #49

Closed RobertGemmaJr closed 3 years ago

RobertGemmaJr commented 3 years ago

Remove volumeData from redux (now in VolumeContext), plus unused variables
Remove Sidebar inline style
Use react-bootstrap buttons (was html)
Color map selection is done through a dropdown (was a Modal)
Saline and Halide color maps added

Sidebar now takes full height of the screen. Still sits on the left side, should we move to the bottom? I don't think that would look as natural but would get it out of the way of the header.

fixes issue #32 (fixed with Camillo's PR #43)
fixes issue #33 (fixed with Camillo's PR #43)
fixes issue #47

github-actions[bot] commented 3 years ago

Visit the preview URL for this PR (updated for commit 158deb4):

https://riddc-volume-viewer--pr49-feat-sidebar-2-jkci9e3k.web.app

_{(expires Tue, 05 Oct 2021 21:44:45 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

mcmcgrath13 commented 3 years ago

It doesn't look like the salinity/temp toggle is updating the color map in the control panel

RobertGemmaJr commented 3 years ago

It doesn't look like the salinity/temp toggle is updating the color map in the control panel

No it's not yet I totally forgot about that. haline is salt and thermal is temperature, correct? I'll have to bridge between redux and context so it may take a second

mcmcgrath13 commented 3 years ago

It doesn't look like the salinity/temp toggle is updating the color map in the control panel

No it's not yet I totally forgot about that. haline is salt and thermal is temperature, correct? I'll have to bridge between redux and context so it may take a second

Yup! that's correct. Also get rid of plasma if it's too close to thermal.

RobertGemmaJr commented 3 years ago

Yup! that's correct. Also get rid of plasma if it's too close to thermal.

Viridis looks the same as haline too, no? I think we should toss that one too

kmilo9999 commented 3 years ago

@RobertGemmaJr Remove viridis and plasma. I downloaded them a while back when I started this project, better keep the official Oceanography colormaps. At the end we are only mapping the color maps as 1D 256x1 array. The value of the textel colors are uniform across their height.

RobertGemmaJr commented 3 years ago

@RobertGemmaJr Remove viridis and plasma.

Sounds good! Just deleted them