search

ridatadiscoverycenter / react-aframe-volume-renderer

afreame-webgl2 volumen renderer as a reactjs app
MIT License
3 stars 0 forks source link

Project cleanup #54

Closed RobertGemmaJr closed 2 years ago

RobertGemmaJr commented 2 years ago

Organize file structure

I changed the components that are now functional components to .jsx files. Will move the others when the context refactoring is finished (separate branch)

I'm not really sure what the best way to organize all the afram stuff is - should Aframe/, libs, loadder/, misc/, and shaders/ all become folders in some parent folder?

github-actions[bot] commented 2 years ago

Visit the preview URL for this PR (updated for commit 3571cf7):

https://riddc-volume-viewer--pr54-project-cleanup-2cadubfj.web.app

(expires Mon, 11 Oct 2021 18:17:14 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

mcmcgrath13 commented 2 years ago

this is a bug I introduced, but could you quickly fix here? Oceanographic => Ocean in the OSOM references 🙏

RobertGemmaJr commented 2 years ago

this is a bug I introduced, but could you quickly fix here? Oceanographic => Ocean in the OSOM references 🙏

So Ocean State Ocean Model, correct? Done!