Opacity Canvas - Values and Units

ridatadiscoverycenter / react-aframe-volume-renderer

afreame-webgl2 volumen renderer as a reactjs app

MIT License

3 stars 0 forks source link

Opacity Canvas - Values and Units #56

Closed kmilo9999 closed 2 years ago

kmilo9999 commented 2 years ago

solves #34

github-actions[bot] commented 2 years ago

Visit the preview URL for this PR (updated for commit a23e114):

https://riddc-volume-viewer--pr56-feature-trans-functi-cqi6ee6o.web.app

_{(expires Fri, 05 Nov 2021 16:20:16 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

kmilo9999 commented 2 years ago

We can wait to merge #63 with master before applying this change.

broarr commented 2 years ago

lol, I realized that one of my suggestions was exactly what you already wrote. I removed it. That's what I get for stream of consciousness reviews ;-)

kmilo9999 commented 2 years ago

@RobertGemmaJr quick check please!

kmilo9999 commented 2 years ago

@RobertGemmaJr let's talk about it in #66 . I already started, but it seems that I am missing some data to make it fully dynamic.