ridatadiscoverycenter / react-aframe-volume-renderer

afreame-webgl2 volumen renderer as a reactjs app
MIT License
3 stars 0 forks source link

Feat custom sidebar #63

Closed RobertGemmaJr closed 2 years ago

RobertGemmaJr commented 2 years ago

Use a custom component for the sidebar so we can remove extra dependencies.

Removes:

A couple questions:

  1. Should we float <Controls /> over <VolumeViewer /> so the volume doesn't get squished when we open them? I'm not 100% sure the best way to go about this
  2. Can we remove the <Spinner /> entirely? I don't think it's adding much information to the website
  3. The dimensions of the <VolumeViewer /> are currently 90vh. Is this the best option?
  4. react-bootstrap 2.0 now supports bootstrap 5.x. I added an issue already to update them but it will create breaking changes, how much should we prioritize it though?

closes issue #39

github-actions[bot] commented 2 years ago

Visit the preview URL for this PR (updated for commit 2e4e5a5):

https://riddc-volume-viewer--pr63-feat-custom-sidebar-1wgw1bk1.web.app

(expires Mon, 01 Nov 2021 14:48:04 GMT)

🔥 via Firebase Hosting GitHub Action 🌎