Closed RobertGemmaJr closed 2 years ago
Visit the preview URL for this PR (updated for commit 2e4e5a5):
https://riddc-volume-viewer--pr63-feat-custom-sidebar-1wgw1bk1.web.app
(expires Mon, 01 Nov 2021 14:48:04 GMT)
🔥 via Firebase Hosting GitHub Action 🌎
Use a custom component for the sidebar so we can remove extra dependencies.
Removes:
primereact
: Dependency needed for the old<Sidebar />
primeicons
: Dependency needed for the old<Sidebar />
react-spinners
: removed becausereact-bootstrap
has its own versionnode-sass
: Dependency needed for the old<Sidebar />
as far as I can tell. No changes have happened since removing it.A couple questions:
<Controls />
over<VolumeViewer />
so the volume doesn't get squished when we open them? I'm not 100% sure the best way to go about this<Spinner />
entirely? I don't think it's adding much information to the website<VolumeViewer />
are currently90vh
. Is this the best option?react-bootstrap 2.0
now supportsbootstrap 5.x
. I added an issue already to update them but it will create breaking changes, how much should we prioritize it though?closes issue #39