riderkick / FMD

Forked from https://sf.net/p/fmd/
GNU General Public License v2.0
719 stars 213 forks source link

e-hentai.org/exhentai.org possible overlong filename/path issue? #332

Closed GramMKII closed 8 years ago

GramMKII commented 8 years ago

task just keeps running, transfer rate indicates data is being downloaded but progress remains at 0/33 even after a while and when I check the chapter folder it remains empty.

sample gallery link

http://g.e-hentai.org/g/958786/033f89507c/

my download path

D:\Manga\

auto gen folder: on remove manga name from ch.: on auto gen chapter folder: on manga folder name: %manga% chapter name: %chapter% filename: %filename%

resulting path (256 chars):

D:\Manga(C89) [Pianissimo (Pija)] Honda-san wa Minna no Honda-san Belongs to Everyone (THE IDOLM@STER CINDERELLA GIRLS) [English] {CapableScoutMan & B.E.C. Scans}(C089) [Pianissimo (Pija)] Honda-san wa Minna no Honda-san Belongs to Everyone\0000.jpg

Now I can temporarily fix the issue by setting the "Chapter Name" to %NUMBERING% but I find it inconvenient to change this every-time I run into this issue since I prefer it to be set to %Chapter% when downloading regular manga.

riderkick commented 8 years ago

I can overcome the limitation by using\\?\. But that seems useless. Because Windows explorer can't access it anyway. So does most of app. And you may find difficulties when trying to delete this files/folders. Maybe strip out all the tags? (C89) [Pianissimo (Pija)] Honda-san wa Minna no _ Honda-san Belongs to Everyone (THE IDOLM@STER CINDERELLA GIRLS) [English] {CapableScoutMan & B.E.C. Scans} become Honda-san wa Minna no _ Honda-san Belongs to Everyone. Btw, you can setup another fmd installation exclusively for h sites, since they usually only have one chapter, you can disable auto generate manga folder. And you can store h and non h in different location.

GramMKII commented 8 years ago

I'd like to be able to keep the tags and using a different fmd installation seems like a roundabout way to solve this issue (i'm sorry <( )>). I'm thinking would it be possible to make use of the advance.ini for per-site config overrides like for example

Options > Websites > Advanced > Config Overrides

then have

Website Config
Exhentai GenerateMangaFolder=0;SaveTo=D:\DefinitelyNotPorn

Though there is still the issue that when the path is too long, fmd just keeps downloading without saving anything (show an error message to let user know maybe?)

Thanks for the disable the 'auto generate manga folder' tip btw. I'll be using this for now.

riderkick commented 8 years ago

It's possible, but currently fmd running with hybrid website module, the new one is easily to initialize. But the old one will need some storage. That will just give more chaos in the source.

riderkick commented 8 years ago

As workaround, if the filename exceeds its available length it will be serialized. That way there will be no duplicate filename, and download will be working normally.

Btw, looking at the url you provide, the filename is perfectly fine, it's serialized number with max length is 4, so there's shouldn't be any problem. Maybe there is another issue, like bad connection.