search

ridgeworks / clpBNR

CLP(BNR) module for SWI-Prolog
MIT License
38 stars 5 forks source link

FIXED: Avoid instantiation of attributed variables in term_html:portray//2 #27

Closed JanWielemaker closed 3 months ago

JanWielemaker commented 3 months ago

term_html:portray//2 is also called for attvars. We must avoid trying to bind these.

ridgeworks commented 3 months ago

Merged in release 0.11.7b.

How/when are these recent changes reflected on swish server (still running 0.11.6)?

JanWielemaker commented 3 months ago

Probably today.

ridgeworks commented 2 months ago

Thanks.

I'm guessing that this fix should also be applied to user:portray/1 for the local case?

JanWielemaker commented 2 months ago

I'm guessing that this fix should also be applied to user:portray/1 for the local case?

No. At least, as-is, user:portray/1 is not called if the term is an attributed variable. For safety you could do this as it might be a better idea to make the call, but changing probably breaks too much.

ridgeworks commented 2 months ago

I'll put it in the queue for my next release; seems like a good idea to "future-proof" the code..