Ready for review

[ridhimamahajan]

Hi @nesquena @timothy1ee

Please review my assignment and let me know your feedback/suggestions.

Thanks for your helpful insights and time!

[nesquena]

Nice work overall Ridhima, few points of feedback / bugs:

• Used FrameLayout to act as a container for timeline tab content
• Setup ActionBar Tabs mode with the Home and Mentions timeline tabs
  • Should checkout tabs cliffnotes to see how you might do this in a Gingerbread compatible way and using a "FragmentTabListener" which is recommended approach by Google.
• Setup the base fragment class that the timelines all extend from
• Setup home timeline fragment without unnecessary code duplication
• Setup mentions timeline fragment without unnecessary code duplication
• OPTIONAL: Should consider implementing endless pagination as a further learning opportunity
• Properly setup user profile view with profile header and a user timeline fragment
  • Can view my profile by clicking on the ActionBar
• Clicking on a users profile image takes me to their profile
  • Click handler setup in getView in adapter
• BUG: When I compose a tweet, it throws an exception.
  • Don't try to replace the fragment manually. Better to just refresh the home timeline if it's in view
  • You could add a public method to the fragment (i.e refreshTimeline) and then in onActivityResult like normal after coming back from compose you could check to see the selected tab from the ActionBar (or just the index and only take the action if the expected tab is selected.
• OPTIONAL: Should play with ActiveAndroid in the future to get a feel for DB persistence

Nice work overall, hopefully you can see this coming together as a "fully fledged" twitter client with some more work and polish. This app contains all of the components now (fragments, models, networking, client, tab navigation, image loading, et al) of 90% of dynamic data-driven API client. Obviously there are lots of details and patterns to learn, but by this point you have been introduced to all the major frameworks and concepts. Hopefully you would feel fairly confident getting started making Android apps for instagram, pinterest, yardsale, flickr, .

Today (Week 5), we are going to cover the last major piece to the Android puzzle and that is using the hardware and SDK components such as the camera, photo gallery, location, maps, etc. After that, Week 6 we will be covering all the topics that separate an intermediate Android developer from a beginner that will act things you should start reviewing to continue your path to being a great Android developer.

Week 7 (Sept 30th), we are going to have a demo day to celebrate the progress you've all made with our next batch of Android students and multiple companies attending to see the group apps that you all have built. We are going to help however we can over the next 2 weeks to get the apps in shape and also have you all prepare a short slide presentation as well.