search

ridiculousfish / libdivide

Official git repository for libdivide: optimized integer division
http://libdivide.com
Other
1.09k stars 77 forks source link

Make the cmake & CI builds use the same settings #82

Closed adbancroft closed 3 years ago

adbancroft commented 3 years ago
  1. Update the cmake build so it has the same compiler flags & options as the CI build
  2. Change the CI build to use cmake only - no CI only options!

Fixes #72

adbancroft commented 3 years ago

On my machine, a test with -DCMAKE_BUILD_TYPE=Sanitize takes a very long time, mainly because of benchmark_branchfree. I think this will blow through any CI allocations. Let's not run benchmark_branchfree in CI.

Appveyor allows 60 minutes per job. With a sanitize benchmark_branchfree, the max job time is ~11 mins (which includes the AVR sim run). It's adding ~3 mins to 2 of the builds, but not close to the limit.

Still want it removed?

ridiculousfish commented 3 years ago

Appveyor allows 60 minutes per job. With a sanitize benchmark_branchfree, the max job time is ~11 mins (which includes the AVR sim run). It's adding ~3 mins to 2 of the builds, but not close to the limit.

Wow. Ok, let's keep it!