ridsuteri / Awesome-Chrome-Extensions

This repository contains awesome chrome extensions
https://ridsuteri.github.io/Awesome-Chrome-Extensions/
MIT License
153 stars 127 forks source link

UI enhanced #477

Closed VasuDevrani closed 1 year ago

VasuDevrani commented 1 year ago

🛠️ Fixes Issue

Solved Issue #473 Enhanced and changed the website UI and code, advanced dark mode, solved bugs like image bug, improved responsiveness

👨‍💻 Changes proposed

✔️ Check List (Check all the applicable boxes)

📄 Note to reviewers

Please merge the request

📷 Screenshots

2022-08-16 2022-08-16 (2) 2022-08-16 (3) 2022-08-16 (4) 2022-08-16 2022-08-16 (1)
gitguardian[bot] commented 1 year ago

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | Secret | Commit | Filename | | | -------------- | ------------------------- | ---------------- | --------------- | -------------------- | | [-](https://dashboard.gitguardian.com/incidents/secrets) | RapidAPI Key | c04e48b7adc4af4723e8c39d90aabc19803a9eb1 | BackgroundRemover/script.js | [View secret](https://github.com/ridsuteri/Awesome-Chrome-Extensions/commit/c04e48b7adc4af4723e8c39d90aabc19803a9eb1#diff-cf3fcc91aecd3ae0b16b14d6e95e8018R28) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | RapidAPI Key | c04e48b7adc4af4723e8c39d90aabc19803a9eb1 | BackgroundRemover/script.js | [View secret](https://github.com/ridsuteri/Awesome-Chrome-Extensions/commit/c04e48b7adc4af4723e8c39d90aabc19803a9eb1#diff-cf3fcc91aecd3ae0b16b14d6e95e8018L28) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/detectors/specifics/rapidapi_key#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/internal-repositories-monitoring/integrations/git_hooks/pre_commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

VasuDevrani commented 1 year ago

Please Note the changes I have made -

VasuDevrani commented 1 year ago

What's the issue? Do I need to anything here

narayan954 commented 1 year ago

There were some merge conflicts that were to be resolved manually. I just did that and checked your work. It's great , Thanks for your contribution.

__ sema-logo  Summary: :trophy: This code is awesome

VasuDevrani commented 1 year ago

Thanks a lot. Please deploy the website too...

narayan954 commented 1 year ago

@VasuDevrani it's because ,you didn't change the index.html but instead created home.html and github pages targets index.html. I didn't notice it earlier as well.

__ sema-logo  Summary: :hammer_and_wrench: This code needs a fix

VasuDevrani commented 1 year ago

Yeah... I was thinking about the same Sorry for that

Then, should i create another pull req for the file rename?

VasuDevrani commented 1 year ago

Hey @narayan954 , I just saw into the repo, it contains some addtional files like stylehelp.js, index.html etc. I haven't created these, are older ones.

narayan954 commented 1 year ago

@VasuDevrani I did some changes , could you lmk if I missed anything ?

VasuDevrani commented 1 year ago

@narayan954 There are few errors yet

image

narayan954 commented 1 year ago

Yeah, you're right, you can work on them but I think we need to raise a new issue mentioning these errors, especially the contributing guidelines.

VasuDevrani commented 1 year ago

No problem I'd be more than happy to help...