Infrequent Crashes when during download/cut

rie-kumar / MusicVideoPlayer

An IPA plugin for playing videos inside BeatSaber

18 stars 3 forks source link

Infrequent Crashes when during download/cut #22

Open b-rad15 opened 4 years ago

b-rad15 commented 4 years ago

Title for me about 1 in 5 downloads cause beatsaber to hang

b-rad15 commented 4 years ago

might be fixed by yield returning the process start but leaving this here incase it comes back

b-rad15 commented 4 years ago

Haven't seen since latest update checking file locks before loading video

b-rad15 commented 4 years ago

Believe it is actually from loading calling LoadVideoSettings too often, after switching to only update the download text on downloadProgress I have not seen this issue on videos that had it happen every time before

Would not really explain the one time it happened after guessoffset but that could've been fixed with the file locking fix

Either way much rarer than it was before so some stuff is better

b-rad15 commented 4 years ago

Will close soon unless anyone can attest to this happening since 9 days ago

JeffReeves commented 4 years ago

I encountered a crash which kicked me completely out of Beat Saber. I was searching for a song with an ampersand (&) in it, if that helps.

b-rad15 commented 4 years ago

I encountered a crash which kicked me completely out of Beat Saber. I was searching for a song with an ampersand (&) in it, if that helps.

This would be after pressing download, right? Also if theres any way you can send the log from that run of the game or if you happened to remember the search term was and video you tried to download, that way I can see if I can reproduce it on my end.

Thank you for reporting this

JeffReeves commented 4 years ago

I don't recall the exact song, but I believe it was: 1999 - Charli XCX & Troye Sivan

I zgrepped through the logs from last night, and this is the only one to match anything with 'ERROR' and 'Music Video Player'. Hopefully it helps you to narrow down the issue:

2020.09.04.22.28.11.log.gz

b-rad15 commented 4 years ago

Can confirm there is a random crash that happens during "custom" searches (where search != default string), possibly a threading/coroutine thing with the search results but shouldn't be since a copy is made before loading the search results

JeffReeves commented 4 years ago

Got another crash. Played the song first without loading a video, then tried to play it again with a video. It crashed the moment I clicked search, without even changing the default string that it populated with.

Here is the log for it: 2020.09.12.00.40.09.log

JeffReeves commented 4 years ago

Flower Dance by DJ Okawari [mapped by Layanmeta w/ KuritsaDBS] was the map/song that it crashed on btw