riebl / vanetza

Open-source implementation of the ETSI C-ITS protocol stack
Other
202 stars 158 forks source link

common: Clock epoch_debug() , timestamp in micros #189

Open mikelngelous opened 1 year ago

mikelngelous commented 1 year ago

In case there are multiple receptions from different services, it is a good idea to know when they arrive, even at the different layers, here is an example in the RouterContext

riebl commented 1 year ago

I like your idea @mikelngelous, I am just not convinced that the string formatting should become a method of vanetza::Clock. Also, calling std::chrono::high_resolution_clock could be quite confusing in the end because "clock ticking" is solely handled by vanetza::Runtime everywhere else.

mikelngelous commented 1 year ago

@riebl you are right. Now I've used runtime to get the timestamp. Do I have to make a new pull request ? also for new contributions like udp unicast that I've pushed

riebl commented 1 year ago

Sorry for my late reply; I have been away for a few days. I prefer to have pull requests per feature, i.e. your UDP feature for socktap would be a separate pull request. What is the reason that you have closed your PR @mikelngelous?

mikelngelous commented 1 year ago

It is reopened again.