Buggy branch fetching - Githubissues

riedeljan / insomnia-universal-git

An Insomnia plugin that aims to help with managing your collections over git

https://exaspace.de

MIT License

17 stars 5 forks source link

Buggy branch fetching #6

Open riedeljan opened 3 years ago

riedeljan commented 3 years ago

When the setup ist completed first the modal has to be submitted and re-opened before a branch can be selected. Same bug occurs when creating a new branch from within the setup.

DCCoder90 commented 3 years ago

If you want I can tackle this. Have some time this weekend that I'll be wrapping up my PR, I can include a fix in for this as well.

riedeljan commented 3 years ago

That‘s awesome, but I‘ve already got the fix in place, just need to finalize it ☺️

Am 13.08.2021 um 13:22 schrieb Ernest Mallett @.***>:

If you want I can tackle this. Have some time this weekend that I'll be wrapping up my PR, I can include a fix in for this as well.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

rafatrace commented 1 year ago

How is the status on this? Seems like dropdown with branches never gets any branch humm Something I can help with?

riedeljan commented 1 year ago

Hi! Didn't really work on this for a while since and would need to have a look. Last time I checked branches fetched fine 🤔 Can you describe what exactly happens on your end and possibly provide output from the dev console? @rafaelcanical

rafatrace commented 1 year ago

Yes sure :) First I opened GitLab - Setup and set all my settings. But dropdown doesn't fill with branches. This is what console returns:

On network tab, this request https://gitlab.com/users/sign_in returns the following:

Headers seem to be set correctly

Edit: (More details)

https://gitlab.com/rafaelcanical/api/v4/projects/{projectId}/repository/branches Fails with status code 302. Doesn't return any response. Request headers seem to be correct

Edit2:

Maybe this is the correct way:

curl --header "PRIVATE-TOKEN: <Acces Token>" "https://gitlab.com/api/v4/projects/<Project ID>/repository/branches"

riedeljan commented 1 year ago

Hmm. U did provide a valid access token with correct scope in the config, right? I'll try to look this up within the day. Maybe some GitLab API changes happened or so.

Also feel free the check out the code and see if you find the culprit before me :) MRs are welcome

rafatrace commented 1 year ago

Its entirely my fault. I was looking in the wrong place, kept checking token and project id correct, but what was wrong was a small typo on baseUrl.

Works great , sorry :/