search

riege / code-quality

Linter configurations and Github Action workflow for super-linter
Universal Permissive License v1.0
3 stars 1 forks source link

Use github.token instead of secrets.GITHUB_TOKEN #15

Closed wiebeck closed 2 years ago

wiebeck commented 2 years ago

Edit: Ok, now I am confused. The doc reads:

The called workflow is automatically granted access to github.token and secrets.GITHUB_TOKEN.

So maybe this PR should not be required at all? On the other hand, why does the check in #13 fail?

Original comment:

Reusable workflows don't have access to caller secrets unless you pass them as secret.

I would like to make the GITHUB_TOKEN even required but that would break existing workflows...

Maybe introduce versioning for breaking changes? ;-)

wiebeck commented 2 years ago

Oh and by the way..... this fixes the validation error in #13