search

riejohnson / ConText

ConText v4: Neural networks for text categorization
http://riejohnson.com/cnn_download.html
GNU General Public License v3.0
124 stars 14 forks source link

DPCNN: weight sharing of convolution units #5

Closed fcharras closed 6 years ago

fcharras commented 6 years ago

Thank you very much for releasing the code.

I'm having a hard time reading https://github.com/riejohnson/ConText/blob/master/examples/dpcnn-functions.sh are the weight of the convolution units intended to be shared across the different layers ?

There's no hint about this in the paper so I think it should not be shared, but this random independent implementation: https://github.com/Cheneng/DPCNN/blob/master/model/DPCNN.py made it so (but I found a few other errors within this repo).

riejohnson commented 6 years ago

are the weight of the convolution units intended to be shared across the different layers ?

No. The weights are not shared by different convolution layers.

fcharras commented 6 years ago

Thank you for the quick response. That pytorch implementation comes above yours in search results, but it has many errors, it can be misleading (even more so with its readme that contains the image of your paper). Might be a plus to contact the author to fix it or link to the official repo.