search

riemann / riemann-dash

An HTTP dashboard for Riemann.
MIT License
248 stars 102 forks source link

Add support for Ruby 3.2 #143

Closed smortex closed 2 months ago

smortex commented 7 months ago

Ruby 2.2 deprecated File#exists? in favor of File#exist?, and Ruby 3.2 removed the deprecated method.

We need to use the "new" method to run on Ruby 3.2.

smortex commented 2 months ago

@jamtur01, can you please approve the run of CI to see if my change help?

smortex commented 2 months ago

Oh, I also see that dependabot opened PRs to update dependencies. Maybe it is a better strategy than removing the Gemfile.lock… It is currently very outdated, and cannot work with recent versions of Ruby, so I think we must do something, either update it or remove it, but the current situation is not good!

smortex commented 2 months ago

Oh, I also see that dependabot opened PRs to update dependencies. Maybe it is a better strategy than removing the Gemfile.lock… It is currently very outdated, and cannot work with recent versions of Ruby, so I think we must do something, either update it or remove it, but the current situation is not good!

I removed + regenerated the Gemfile.lock so that it indicates it was generated with a recent version of bundler instead of a legacy one. This avoids Ruby to use this legacy version of bundler with recent ruby that use legacy features which are not part of Ruby anymore. Dependabot will tell us when updates for dependencies will be available, and allows users to run the exact same bundle as the one used for unit testing if they want.