search

riemann / riemann-dash

An HTTP dashboard for Riemann.
MIT License
248 stars 102 forks source link

Grid view features #31

Closed crohn closed 11 years ago

crohn commented 11 years ago

Hi there,

at work we're using riemann and riemann-dash to monitor our production environment.

Having lots of metrics to keep an eye on, we found useful the possibility to scroll each Grid view independently in a single tab. Furthermore, sometimes it could be more effective organizing the Grid for having metrics in rows instead of hosts.

In the code I added

overflow: auto;

to grid class in the stylesheet and a transpose field, in grid.js.

aphyr commented 11 years ago

Transpose functionality is already in the grid: just swap the order of "service" and "host" in the rows and columns fields. Since the grid is pretty complex already, I think I'd like to avoid bringing this particular option in.

luca3m commented 11 years ago

Hi

I work with chron and we discussed together this pull request. We haven't seen rows/columns feature, so I agree with you that is already possible to do "transposition"

What about overflow: auto instead? I think it's useful when you have a lot of metrics. It's a pretty small change.

aphyr commented 11 years ago

Yeah, I'll take an overflow:auto patch. Want to make a separate PR for it?

luca89 notifications@github.com wrote:

Hi

I work with chron and we discussed together this pull request. We haven't seen rows/columns feature, so I agree with you that is already possible to do "transposition"

What about overflow: auto instead? I think it's useful when you have a lot of metrics. It's a pretty small change.

— Reply to this email directly or view it on GitHub.

crohn commented 11 years ago

Yes, I'm going to make a separate PR. Thank you.