search

riemann / riemann-dash

An HTTP dashboard for Riemann.
MIT License
248 stars 102 forks source link

Add two new key binding a fix another one. #7

Closed fcuny closed 11 years ago

fcuny commented 11 years ago

Add two new bindings: one for help ('?') and another one to delete a view ('d'). The last one is in addition to the 'delete' key, since some browser bind this to "previous page in history".

Also, the correct key code (at least on Mac's QWERTY keyboard) for the letter 'h' is 72.

fcuny commented 11 years ago

If there's a good reason to have vertical split bind to 87, let me know and I'll fix my patch.

aphyr commented 11 years ago

Ah, you're right, I was using w for hsplit. It probably should be h. :)

I don't want to change delete's binding, though. 46 is delete, 8 is backspace. I'll merge your patch, but change that binding back.

aphyr commented 11 years ago

Thanks for adding the help window, too! Added you to the contributors file. :+1: