tls_ca_file not included in container registration

riemers / ansible-gitlab-runner

Ansible role to install gitlab-runner

MIT License

351 stars 267 forks source link

tls_ca_file not included in container registration #318

Closed citypilgrim closed 7 months ago

citypilgrim commented 8 months ago

Hi @riemers, thank you for the awesome ansible role! This might not qualify as an issue, but I realised that the tasks/register-runner-container.yml is missing the lines

      {% if gitlab_runner.tls_ca_file|default(false) %}
      --tls-ca-file "{{ gitlab_runner.tls_ca_file }}"
      {% endif %}

in the registration command.

Why is it that we do not specify tls-ca-file when using a docker executor?

github-actions[bot] commented 7 months ago

Seems this message did not get a lot of love. This does not mean it was not seen but time wise might not have made it to proper attention. This is just the clean up action ;)