riemers / ansible-gitlab-runner

Ansible role to install gitlab-runner
MIT License
351 stars 266 forks source link

docs: Clarify registration_token requirement #348

Closed Vesther closed 2 months ago

Vesther commented 2 months ago

Hi there,

this Merge Request aims to clarify the documentation regarding the use of the gitlab_runner_registration_token. I initially understood the current wording, it is recommended to specify a token for each runner as a suggestion rather than a requirement. The clarification here highlights that specifying a token for each runner is required, not just recommended, when gitlab_runner_registration_token_type is set to authentication-token.

An alternative proposal would be allowing the global gitlab_runner_registration_token to be used with the --token command by default in the same way it works with the --registration-token option. That would simplify the process for registering multiple runners, as in the current GitLab Release it is intended to reuse a single token to register multiple hosts grouped as a single runner.

guenhter commented 2 months ago

Thx for this contribution