search

rien / reStream

Stream your reMarkable screen over SSH.
MIT License
734 stars 56 forks source link

Options #10

Closed AaronDavidSchneider closed 4 years ago

AaronDavidSchneider commented 4 years ago

added wifi fallback.

Sorry PR contains a merge commit... Is that ok?

Closes #8

beardhatcode commented 4 years ago

Cool, how much lag do you have over WiFi?

AaronDavidSchneider commented 4 years ago

@beardhatcode: I experienced similar lag in wifi and usb. Just give it a try.

beardhatcode commented 4 years ago

I get a lot more lag, as I expected, sometimes more than a second on my home network. But it works :), and for some use cases lag isn't that important.

AaronDavidSchneider commented 4 years ago

Interesting. I think it depends strongly on your network architecture if this works well. However thats why I implemented wifi as a fallback in this PR. People who use usb anyway won't notice a difference.

AaronDavidSchneider commented 4 years ago

Thank you for your feedback. I guess using the -h option would be fine too. The nested if statements could however be merged if this would help.

I am not familiar with getopt (actually neither with bash scripting in general). I will give it a try.

AaronDavidSchneider commented 4 years ago

I just found out that getopt is not installed on every unix system as default. The method I implemented in #11 should work in any case