rien / reStream

Stream your reMarkable screen over SSH.
MIT License
732 stars 56 forks source link

ffmpeg snap compatibility is broken by ffplay naming convention #59

Closed psigen closed 5 months ago

psigen commented 3 years ago

I was able to get reStream working very easily on Ubuntu with only the following two snaps:

sudo snap install ffmpeg lz4

However, the ffmpeg snap packages ffplay as ffmpeg.ffplay, so I had to manually edit reStream.sh to use that instead of the default command ffplay. I was wondering if there was a reasonable way to support this use, since it's really nice to only depend on two confined snaps from an installation perspective.

Here are some options:

Eeems commented 3 years ago

My suggestion would be to alias ffplay as ffmpeg.ffplay instead of modifying the script.

gullradriel commented 5 months ago

Just so I know, why are you using snap installs and not direct host versions if you're on Ubuntu ? sudo apt-get install ffmpeg lz4 isn't working ? I would find it strange.

psigen commented 5 months ago

There are a few reasons why someone would want to use snap installs

So there are a number of reasons why people use snaps. You can read more about them here: https://snapcraft.io/docs

gullradriel commented 5 months ago

Thanks 👍

rien commented 5 months ago

Feel free to make a PR to put the ffplay and ffmpeg executables in an environment variable. However it is also easily fixable by replacing the ffplay command in the script.

I'll close this issue for now at has been open for quite a while 🙂