rien7 / obsidian-colorful-tag

Make your tag more beautiful and powerful!
Apache License 2.0
126 stars 3 forks source link

Colorful-Tag 1.3.0's mechanism for automatically updating Frontmatter interferes with normal use. #44

Open alexinea opened 1 year ago

alexinea commented 1 year ago

Colorful-Tag is such a great plugin, I can't live without it. But when using 1.3.0, I have some problems.

After updating to 1.3.0, Tag Detail is automatically written to Frontmatter. The current design is to automatically refresh Frontmatter, and this mechanism will affect the normal use of Frontmatter.

This automatic refresh mechanism gave me a lot of troubles and caused me to delay some work. I wonder if it is possible to add an option not to automatically refresh Frontmatter, but manually refresh it through a shortcut key.

Looking forward to your reply.

Thx:)

ArneNostitz commented 1 year ago

same here. i dont want to mess up my Frontmatter at all. i use it quite extensively. but I don't want other data in there. had to delete the colorful tag plugin because I couldn't stop it from changing my yaml.

what is the usecase for this ?

rien7 commented 1 year ago

same here. i dont want to mess up my Frontmatter at all. i use it quite extensively. but I don't want other data in there. had to delete the colorful tag plugin because I couldn't stop it from changing my yaml.

what is the usecase for this ?

Sorry, the next version will provide the option to disable this feature

ArneNostitz commented 1 year ago

hi - please excuse the maybe harsh sounding msg before - didnt mean to offend you. dont be sorry - its a wonderful tool you provide for the community - so thank you very much for all your hard work ... i am sure there is a reason for this feature that for sure took some time to implement - i just dont get it :)

thank you again for the plugin and your commitment - have some great holidays

rien7 commented 1 year ago

I had added an option to save the data in plugin #45

tobiasvl commented 1 year ago

It's nice that this will be made optional in the next release, but even so, I feel like there must be some unintended behavior here? I'm not sure what causes it, if there's an interference with other plugins, but I use Daily Notes with the Rollover Daily Todos plugin, which rolls over my incomplete checkboxes (which use Colorful Tag), and this is how my frontmatter looks in a fresh daily note now:

---
tags: daily
prev: "[[2022-12-19]]"
next: "[[2022-12-21]]"
colorful-tag:
  - {}
  - {}
  - {}
  - {}
  - {}
  - {}
  - {}
  - {}
  - {}
  - {}
  - {}
  - {}
  - {}
  - {}
  - {}
  - {}
  - {}
  - {}
  - {}
  - {}
  - {}
  - {}
  - {}
  - {}
  - {}
  - {}
  - {}
---

Surely that's not intentional? Looks like it's one entry per tag, but they're all empty...

rien7 commented 1 year ago

It's nice that this will be made optional in the next release, but even so, I feel like there must be some unintended behavior here? I'm not sure what causes it, if there's an interference with other plugins, but I use Daily Notes with the Rollover Daily Todos plugin, which rolls over my incomplete checkboxes (which use Colorful Tag), and this is how my frontmatter looks in a fresh daily note now:


---

tags: daily

prev: "[[2022-12-19]]"

next: "[[2022-12-21]]"

colorful-tag:

  - {}

  - {}

  - {}

  - {}

  - {}

  - {}

  - {}

  - {}

  - {}

  - {}

  - {}

  - {}

  - {}

  - {}

  - {}

  - {}

  - {}

  - {}

  - {}

  - {}

  - {}

  - {}

  - {}

  - {}

  - {}

  - {}

  - {}

---

Surely that's not intentional? Looks like it's one entry per tag, but they're all empty...

if you use tag details, it will add tag detail data into the frontmatter.

For now, this plugin will record all the tags of the file instead of the tags which using tag details.

if you don't want the plugin modify the frontmatter, you can consider to select "Plugin" instead of "Frontmatter" in "General Setting" of this plugin.

bwydoogh commented 1 year ago

select "Plugin" instead of "Frontmatter" in "General Setting" of this plugin

Could you make a new release? The manifest.json still refers to 1.3.0 (thus no update seen by Obsidian)

rien7 commented 1 year ago

select "Plugin" instead of "Frontmatter" in "General Setting" of this plugin

Could you make a new release? The manifest.json still refers to 1.3.0 (thus no update seen by Obsidian)

I forgot it, now it has been modified

tobiasvl commented 1 year ago

Fantastic, thanks! Note that I had to restart Obsidian to make it take effect.

alexinea commented 1 year ago

Wonderful. Thanks to the author. Praise the author.

dzhuyx commented 1 year ago

If I turn "Enable Tag Detail" off and change to "Store Tag Detail in Plugin", I still observe this behavior with yaml. But if I enable tag detail and use the "Plugin" option, then there is no bug. Just wanted to provide some info/feedback on how the plug-in is behaving in case this is helpful.

rien7 commented 1 year ago

If I turn "Enable Tag Detail" off and change to "Store Tag Detail in Plugin", I still observe this behavior with yaml. But if I enable tag detail and use the "Plugin" option, then there is no bug. Just wanted to provide some info/feedback on how the plug-in is behaving in case this is helpful.

thanks for your feedback, i will fix it next version