search

rienafairefr / pynYNAB

a python client for the new YNAB
MIT License
138 stars 12 forks source link

_add_transactions() fails on master and latest tag #36

Closed noamelf closed 6 years ago

noamelf commented 7 years ago

Hi, First of all, thanks a lot for creating this package! It's really helpful for automation.

Running the csvimport script fails with this message on master branch and 0.5 tag: 

  File "csvimport.py", line 186, in <module>
    csvimport_main()
  File "csvimport.py", line 42, in csvimport_main
    do_csvimport(args)
  File "csvimport.py", line 182, in do_csvimport
    client.add_transactions(transactions)
  File "/home/noam/projects/open-source/pynYNAB/pynYNAB/Client.py", line 339, in add_transactions
    self._add_transactions(chunkelement)
TypeError: _add_transactions() takes exactly 2 arguments (1 given)

Reverting to 0.4.3 solves the problem, so I guess it's some commit in between.

rienafairefr commented 7 years ago

Sorry, the csvimport is kinda unused so it lagged behind the rest of the library. I'll look into it

On Mar 24, 2017 23:00, "Noam Elfanbaum" notifications@github.com wrote:

Hi, First of all, thanks a lot for creating this package! It's really helpful for automation.

Running the csvimport script fails with this message on master branch and 0.5 tag:

File "csvimport.py", line 186, in csvimport_main() File "csvimport.py", line 42, in csvimport_main do_csvimport(args) File "csvimport.py", line 182, in do_csvimport client.add_transactions(transactions) File "/home/noam/projects/open-source/pynYNAB/pynYNAB/Client.py", line 339, in add_transactions self._add_transactions(chunkelement) TypeError: _add_transactions() takes exactly 2 arguments (1 given)

Reverting to 0.4.3 solves the problem, so I guess it's some commit in between.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/rienafairefr/pynYNAB/issues/36, or mute the thread https://github.com/notifications/unsubscribe-auth/AAuS9SwMkDJ-wntC1PTP5UQh_QNyukoPks5rpD0CgaJpZM4Mo0IR .

rienafairefr commented 7 years ago

Hey @noamelf, can you check back on the status of this ? I just reorganised the way the scripts are invoked are transactions pushed, I think there should be no problem now, with latest master b714999

noamelf commented 7 years ago

Hi, thanks that was quick! I got 2 errors while rerunning it. The first: ImportError: No module named ofxtools

After installing ofxtools, I run it again and received: No handlers could be found for logger "pynYNAB.__main__"

chbndrhnns commented 6 years ago

@noamelf: I had the same issue but you could try again now as some fixes were made.