Agenda: truncate `ids` element value to its max length (19)

riesenia / pohoda

XML generator a parser pre Pohodu

35 stars 29 forks source link

Agenda: truncate `ids` element value to its max length (19) #14

Closed Ciki closed 4 years ago

Ciki commented 5 years ago

as per spec

Ciki commented 4 years ago

@segy would you merge this PR please?

segy commented 4 years ago

i missed this one. but i won't... sorry. there is a problem with stockIdsType for instance. by definition it's 64 chars long. and there are also many other different definitions (see carrierType or MOSStype etc). btw... i don't that validating so strictly everything is good approach. if you need exact definitions, it's probably better to generate classes using xsd2php. of course the usage won't be this simple.

Ciki commented 4 years ago

I see, didn't know about the differences. I'll handle it on my side then..