Tests for db queries - Githubissues

riesgos / async

0 stars 0 forks source link

Tests for db queries #94

Closed nbrinckm closed 1 year ago

nbrinckm commented 1 year ago

Improves the situation for Issue https://github.com/riesgos/async/issues/93

nbrinckm commented 1 year ago

I currently try to migrate the python tests that I wrote to be done in kotlin. However, the h2 db is quite hard to handle at the moment:

it doesn't start from a really a clean state (without any database migrations)
it doesn't accept the syntax that I used in the persist classes

nbrinckm commented 1 year ago

Ok, now I have all the tests in kotlin (and no longer any python tests). All modifications that were needed to make the tests pass were also done in this pull request.

To run the new tests, you can use the mvn_test.sh script that just runs those new tests (without the overall spring context initialization, that has some problems with the pulsar).

nbrinckm commented 1 year ago

I think for a later stage, someone with more knowledge about spring boot jdbc testing could refactor it a bit (so that not all of my hacks are needed anymore).

@MichaelLangbein How do you think, could I merge it now?

MichaelLangbein commented 1 year ago

Brilliant! Looks good to me!