riesgos / buildall

Repository for building and running all of riesgos' services
Apache License 2.0
0 stars 1 forks source link

Integrate frontend #3

Closed MichaelLangbein closed 1 year ago

MichaelLangbein commented 1 year ago
MichaelLangbein commented 1 year ago

@nbrinckm : i'll request a review once https://github.com/riesgos/buildall/pull/7 is merged.

MichaelLangbein commented 1 year ago

Aaaaall-right; Got the compose files working together. Reason it didn't work at first was that one file was on another path than the first. Docker compose tries to resolve relative paths in compose-files relative to the dir in wich the compose command is called ... which was off for dlr's compose-file, since that was in a sub-dir.

I'm currently getting an error from the backend-container, but that's a separate issue. Will fix that and then hopefully move on to another review.

MichaelLangbein commented 1 year ago

Docker compose tries to resolve relative paths in compose-files relative to the dir in wich the compose command is called ... which was off for dlr's compose-file, since that was in a sub-dir.

Seems that's not correct: relative paths are resolved relative to the first compose file used in the compose-command. See here: https://github.com/docker/compose/issues/4851

MichaelLangbein commented 1 year ago

Found an interesting problem.

For the backend to be able to talk to the WPSes, we'd need them to send back an ExecuteResponse with its docker-internal address.

On the other hand, if we want a WPS to be available to the outside world, we'd need it to respond with its external address. I think this latter problem can be solved with the upcoming proxy, though... ... I think that proxy might already be merged in main (btw thanks @nbrinckm ), so I'll try out that.