UnitTest failure - Githubissues

rietho / IPO

A Tool for automated Optimization of XCMS Parameters

http://bioconductor.org/packages/IPO/

Other

34 stars 20 forks source link

UnitTest failure #7

Closed sneumann closed 9 years ago

sneumann commented 9 years ago

Hi, one value in the unit tests seems to have slightly changed, most likely requires just updating the expected value or tolerance.

Running the tests in ‘tests/runTests.R’ failed.
Last 13 lines of output:
  IPO RUnit Tests - 1 test function, 0 errors, 1 failure
  FAILURE in test_ipo: Error in checkEqualsNumeric(unlist(TV)[4], 0.0006312929, tolerance = 1e-06) : 
    Mean relative difference: 0.006195529

glibiseller commented 9 years ago

Hi!

The unit test finished without an error on my windows machine:

R version 3.1.1 (2014-07-10)
Platform: i386-w64-mingw32/i386 (32-bit)
IPO 1.6.2
xcms_1.42.0

but does not on linux:

R version 3.0.0 (2013-04-03)
Platform: x86_64-pc-linux-gnu (64-bit)
IPO 1.6
xcms_1.42.0

Changing the tolerance to 1e-03 would solve the problem on the linux machine.

Maybe its due to 32 and 64 bit enviroments. What do you think?

sneumann commented 9 years ago

increase tolerance would be fine with me, if that's what one can expect across platforms.

glibiseller commented 9 years ago

I updated the tolerance. Now the tests work fine on 32 and 64 bit.