search

rietho / IPO

A Tool for automated Optimization of XCMS Parameters
http://bioconductor.org/packages/IPO/
Other
34 stars 20 forks source link

Fix/mz data removal #70

Closed sneumann closed 2 years ago

sneumann commented 2 years ago

Hi, move from mzData to mzML. Closes #69

rietho commented 2 years ago

Thanks @sneumann. Can you confirm that this code change should work? I am not performing any checks on the code. But if you give your go, I'll merge the code.

sneumann commented 2 years ago

That deprecation came in through @lshep because eMails bounced and unresponsive maintainers of broken packages cause deprecation. After fixing I think we can un-deprecate ? We should also update the maintainer eMail. I'd love to have you there, but will be happy to assist when possible. And yes, I did run R CMD check, so I am positive it works :-) Yours, Steffen

rietho commented 2 years ago

Thanks. I just merged the PR.

I'll check back after my upcoming vacation to update the maintainer email.

rietho commented 2 years ago

If things turn out fine, I may also undeprecate.

It's not ideal that IPO keeps living in my space, but as it's open source and if it's useful, better here than nowhere.

lshep commented 2 years ago

@rietho Don't undeprecate yourself -- please make sure it is building without ERROR on the Bioconductor RELEASE_3_15 branch and then request undeprecation at bioc-devel@r-project.org cc: lori.shepherd@roswellpark.org if you plan to keep it in Bioconductor. It has been removed from devel 3.16 and will only be added back after undeprecation on the RELEAES_3_15 branch

rietho commented 2 years ago

Thanks @lshep for the clarification on the un-deprecation process.