rietveld-codereview / rietveld

Code Review, hosted on Google App Engine
https://codereview.appspot.com
Apache License 2.0
556 stars 152 forks source link

Fix for upload.py and svn with externals #100

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Setup an svn repo with externals.
2. Make a change (do not touch externals)
3. Try to upload the codereview to codereview using upload.py

What is the expected output? What do you see instead?
I get the following error:
svn status returned unexpected output: X      scripts/googlecode

What version of the product are you using? On what operating system?
r407 on Mac OS X

Please provide any additional information below.
Attached you will find a patch that fixes the problem.

Original issue reported on code.google.com by evlogimenos on 26 Mar 2009 at 1:29

Attachments:

GoogleCodeExporter commented 9 years ago
AFAICT this could only occur if "scripts/googlecode" is listed in the output
generated by "svn diff". Otherwise the function that raises this error should 
not be
called with that file.

Which version of svn are you using? Do you use svn's builtin diff command or an
external program (possibly in your svn config by setting a custom "diff-cmd" 
option)?

BTW, please upload patches to codereview ;-)

Original comment by albrecht.andi on 30 Mar 2009 at 7:26

GoogleCodeExporter commented 9 years ago

Original comment by albrecht.andi on 6 Apr 2012 at 7:19