rietveld-codereview / rietveld

Code Review, hosted on Google App Engine
https://codereview.appspot.com
Apache License 2.0
556 stars 152 forks source link

Can't reply to top-level message and "publish + mail comments" at once #212

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Alice uploads a patchset to codereview.appspot.com/XYZ 
   and asks for review by doing "Publish+Mail comments"
2. Bob adds some inline comments and also he writes a reply to the Alice's 
message at
   codereview.appspot.com/XYZ (not codereview.appspot.com/XYZ/publish!).
   He clicks "send message".   
3. Alice only receives the reply, but not comments. Comments are invisible for 
Alice.
4. Bob has to do "Publish+Mail comments" to show his inline comments to Alice.

What is the expected output? What do you see instead?
  at step 3, Alice should receive both the reply and inline comments.
  Comments should be visible for Alice at step 3.
  Probably this can be optional (by checkbox?)

*** If you are a Google employee please say so or mail me (Guido van
Rossum) directly. ***
Yes, I'm a Google Employee.
Filing a public issue so I can share it with other people I work with in 
open-source projects.

Original issue reported on code.google.com by timurrrr@google.com on 30 Jul 2010 at 3:15

GoogleCodeExporter commented 9 years ago

Original comment by albrecht.andi on 2 Aug 2010 at 6:40

GoogleCodeExporter commented 9 years ago

Original comment by albrecht.andi on 6 Apr 2012 at 6:20