search

rietveld-codereview / rietveld

Code Review, hosted on Google App Engine
https://codereview.appspot.com
Apache License 2.0
556 stars 152 forks source link

side-by-side view and in-file comment publishing fails for big file (>10,000 lines) #280

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. submit a patch in a big file (>10,000 lines)
2. open the issue and try to see side-by-side
OR
3. click in the Unified View
4. add a comment in any line
5. publish it ('m')

What is the expected output? What do you see instead?
In [2.]:
I expected to see the side-by-side view but receive an "Oops! This link appears 
to be broken." error message.

In [5.]:
I expected to send the message but get a 500 Server error message.

What version of the product are you using? On what operating system?
http://codereview.appspot.com/4272055/

*** If you are a Google employee please say so or mail me (Guido van
Rossum) directly. ***

Please provide any additional information below.
I created an entry only to test this:
http://codereview.appspot.com/4272055/

The problem happens in any patch against the readfile.c in Blender trunk source 
code. I'm assuming that happens because of the file size (it's one of the 
biggest in our database). Patch against other files are working well. This 
problem happens when the patch only alter this file (as 4272055) or if it 
includes other changes as well (as 4289041)

As an example of a direct link to the [2.] problem:
http://codereview.appspot.com/4272055/diff/1/source/blender/blenloader/intern/re
adfile.c

For an example of a real entry with a patch for this file (which fails) and 
other files (which worked):
http://codereview.appspot.com/4289041/

Thanks

Original issue reported on code.google.com by dfeli...@gmail.com on 17 Mar 2011 at 5:26

GoogleCodeExporter commented 9 years ago 
We simply hit the deadline of urlfetch.fetch() which defaults to 5 seconds on 
that file. You can easily reproduce it for example on http://shell.appspot.com 
with the following code snippet:

from google.appengine.api import urlfetch
# the following fails (most likely)
f = 
urlfetch.urlfetch("https://svn.blender.org/svnroot/bfblender/trunk/blender/sourc
e/blender/blenloader/intern/readfile.c?rev=35577")
# and with increased deadline it should work
f = 
urlfetch.urlfetch("https://svn.blender.org/svnroot/bfblender/trunk/blender/sourc
e/blender/blenloader/intern/readfile.c?rev=35577", deadline=10)

Original comment by albrecht.andi on 18 Mar 2011 at 7:56

GoogleCodeExporter commented 9 years ago 
Wow. Great test case playground. Thanks for sharing.

Original comment by techtonik@gmail.com on 18 Mar 2011 at 4:04

GoogleCodeExporter commented 9 years ago

Original comment by albrecht.andi on 6 Apr 2012 at 6:20