Added binary image causes 500 error

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Take an existing git repository
2. Add a png image
3. upload changeset, see 500 error

What is the expected output? What do you see instead?
Expect to see a binary upload but see text upload.

At what URL are you accessing Rietveld?  (e.g. codereview.appspot.com)
Please note if you are using the Google Apps Labs version (e.g.
codereview.<yourdomain>).
Using privately hosted version.

Please provide any additional information below.
Applied a patch that fixed it for us.

Original issue reported on code.google.com by sportjun...@gmail.com on 29 Dec 2011 at 6:24

Attachments:

• add_binary_image.patch

[GoogleCodeExporter]

Could you please upload the patch to codereview.appspot.com. From my POV it 
looks nice, but maybe someone else on the developer list has some comments :)

BTW, have you already signed a Individual Contributor License Agreement (see 
http://code.google.com/p/rietveld/wiki/Contributing under "Legal Stuff" for 
deails)?

Original comment by albrecht.andi on 21 Jan 2012 at 8:02

• Changed state: Accepted
• Added labels: ****
• Removed labels: ****

[GoogleCodeExporter]

No I have not signed the agreement. Have to do that at some point. Also I have 
not uploaded the patch either, it still has flaws with binary files. The patch 
only solves problems when adding a new binary image but the upload still fails 
for us when we try to upload a modified binary. We hacked an ugly try except 
into the upload.py to make it work but don't see it as a final solution.

Original comment by sportjun...@gmail.com on 8 Feb 2012 at 4:35

• Added labels: ****
• Removed labels: ****

[GoogleCodeExporter]

Thanks for the feedback! Let us know when you've a patch ready for review!

Original comment by albrecht.andi on 9 Feb 2012 at 1:59

• Added labels: ****
• Removed labels: ****

[GoogleCodeExporter]

Original comment by albrecht.andi on 6 Apr 2012 at 6:31

• Added labels: Component-Engine
• Removed labels: ****