search

rietveld-codereview / rietveld

Code Review, hosted on Google App Engine
https://codereview.appspot.com
Apache License 2.0
560 stars 152 forks source link

an encoded web link is being double encoded #498

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. paste a link with % in it (already encoded) to message; ex: 
http://jenkins.xxx.xxx:8080/view/open%20util/job/test-job/
2. publish the review
3. click on the link

What is the expected output? What do you see instead?
i should be redirected to 
http://jenkins.xxx.xxx:8080/view/open%20util/job/test-job/
but the link has been double encoded to 
http://jenkins.xxx.xxx:8080/view/open%2520util/job/test-job/
(%20 become %2520)

What browser are you using?  What version? On what operating system?
chrome 36.0.1985.125, mac OS x 10.5.8

At what URL are you accessing Rietveld?  (e.g. codereview.appspot.com)
Please note if you are using the Google Apps Labs version (e.g.
codereview.<yourdomain>).
i'm using the google apps lab version.

Please provide any additional information below.
Codereview tool should probably validate the link before it encodes it again.

Original issue reported on code.google.com by dap...@cohesity.com on 23 Jul 2014 at 7:28