search

rietveld-codereview / rietveld

Code Review, hosted on Google App Engine
https://codereview.appspot.com
Apache License 2.0
560 stars 152 forks source link

Replace /ClientLogin with /ClientAuth #519

Closed myk-google closed 9 years ago

myk-google commented 9 years ago

Currently upload.py is broken across many Google projects. Rather than just making the one-line change locally, I wanted to share it with you.

andialbrecht commented 9 years ago

Looks like the problem is a little bit bigger: This authentication method is deprecated since 2012 and the endpoint will be shutdown in 12 days.

https://developers.google.com/identity/protocols/AuthForInstalledApps

myk-google commented 9 years ago

I think that (at least within Google) it was shut down yesterday -- I can see a couple of dozen CLs amongst a whole lot of teams making a very similar change all over different systems. -- Marc

On Wed, Apr 8, 2015 at 11:45 AM, Andi Albrecht notifications@github.com wrote:

Looks like the problem is a little bit bigger: This authentication method is deprecated since 2012 and the endpoint will be shutdown in 12 days.

https://developers.google.com/identity/protocols/AuthForInstalledApps

— Reply to this email directly or view it on GitHub https://github.com/rietveld-codereview/rietveld/pull/519#issuecomment-91001453 .

andialbrecht commented 9 years ago

Merged, since both versions work. At least today :)