search

rietveld-codereview / rietveld

Code Review, hosted on Google App Engine
https://codereview.appspot.com
Apache License 2.0
556 stars 152 forks source link

'Patch set is too large to download', git cl patch gives 404 #527

Open cdotstout opened 9 years ago

cdotstout commented 9 years ago

CL has about 320 files. Is this really considered too large? https://codereview.chromium.org/1259423003/

git cl patch 1259423003: https://paste.googleplex.com/6558001435508736

andialbrecht commented 9 years ago

Rietveld limits responses to 1MB, IIRC. It's likely that a cl with 320 files exceeds this limit.

This limit was necessary in the early ages of Appengine. I'm not sure if this quota limit is still relevant. However, we've never changed it.

IMO such large cl are not reviewable so I have not much interest in changing this limit - but that's just my very own opinion :)