rietveld-codereview / rietveld

Code Review, hosted on Google App Engine
https://codereview.appspot.com
Apache License 2.0
560 stars 152 forks source link

mapreduce subversion no more available #546

Open cedk opened 8 years ago

cedk commented 8 years ago

The Makefile tries to checkout the revision 491 of the mapreduce subversion. But mapreduce project has migrated to https://github.com/GoogleCloudPlatform/appengine-mapreduce I do not know if the mapreduce.patch is still needed, but it should at least be changed in Makefile to use a git clone.

cedk commented 8 years ago

Indeed we could fork mapreduce, apply the patch and use a git submodule

landyu commented 7 years ago

i just comment mapreduce:

svn co -r 491 http://appengine-mapreduce.googlecode.com/svn/trunk/python/src/mapreduce

cd mapreduce/ && patch < ../mapreduce.patch

and

includes:

- mapreduce/include.yaml

it works....

landyu commented 7 years ago

mapreduce

mapreduce:
    git submodule add https://github.com/GoogleCloudPlatform/appengine-mapreduce
    cd appengine-mapreduce/python/src/mapreduce/ && patch < ../../../../mapreduce.patch
includes:
- appengine-mapreduce/python/src/mapreduce/include.yaml