rietveld-codereview / rietveld

Code Review, hosted on Google App Engine
https://codereview.appspot.com
Apache License 2.0
560 stars 152 forks source link

upload.py: Store oauth tokens in ~/.codereview_upload_tokens #547

Closed cedk closed 6 years ago

cedk commented 8 years ago

This prevents one round trip to the server to get oauth token and also prevent to type the token each time when not using the browser to get it. When the token becomes invalid, the next try will refresh the token.

cedk commented 7 years ago

ping @andialbrecht

cedk commented 7 years ago

up @andialbrecht

andialbrecht commented 6 years ago

@cedk, do you think we need a command line flag for users who don't want their token to be saved?

cedk commented 6 years ago

We could reuse the save_cookies option? I added this in b9a4c26428001113a9dc30adc946b5e59b802ef5

cedk commented 6 years ago

@andialbrecht Do you think this could be merged now?

andialbrecht commented 6 years ago

I'm sorry for the long delay! Thanks @cedk! I'll upload the new version tomorrow.

andialbrecht commented 6 years ago

....and it's live

cedk commented 6 years ago

Great, thanks.